Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logline mentioning plugin api #4459

Merged
merged 1 commit into from
May 13, 2024
Merged

fix logline mentioning plugin api #4459

merged 1 commit into from
May 13, 2024

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented May 11, 2024

Description

This PR changes a logline that was merged at the time in which we implemented the webhook functionality. This was originally called "plugin" and it looks like a logline mentioning the old name is still in the codebase. This PR renames that to webhook.

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: Raffaele Di Fazio <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2024
@mloiseleur
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit d422e39 into master May 13, 2024
14 checks passed
truecharts-admin referenced this pull request in truecharts/public May 17, 2024
…rnal-dns to v0.14.2@3fcad62 by renovate (#22163)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[registry.k8s.io/external-dns/external-dns](https://togithub.com/kubernetes-sigs/external-dns)
| patch | `v0.14.1` -> `v0.14.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>kubernetes-sigs/external-dns
(registry.k8s.io/external-dns/external-dns)</summary>

###
[`v0.14.2`](https://togithub.com/kubernetes-sigs/external-dns/releases/tag/v0.14.2)

[Compare
Source](https://togithub.com/kubernetes-sigs/external-dns/compare/v0.14.1...v0.14.2)

#### What's Changed

- kustomize-v0.14.1 by [@&#8203;Raffo](https://togithub.com/Raffo) in
[https://github.com/kubernetes-sigs/external-dns/pull/4331](https://togithub.com/kubernetes-sigs/external-dns/pull/4331)
- replace all links in tutorials for v0.14.1 by
[@&#8203;Raffo](https://togithub.com/Raffo) in
[https://github.com/kubernetes-sigs/external-dns/pull/4332](https://togithub.com/kubernetes-sigs/external-dns/pull/4332)
- chore: upgrade ExternalDNS to go 1.22 by
[@&#8203;mloiseleur](https://togithub.com/mloiseleur) in
[https://github.com/kubernetes-sigs/external-dns/pull/4318](https://togithub.com/kubernetes-sigs/external-dns/pull/4318)
- build(deps): bump the dev-dependencies group with 13 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4329](https://togithub.com/kubernetes-sigs/external-dns/pull/4329)
- build(deps): bump the dev-dependencies group with 5 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4334](https://togithub.com/kubernetes-sigs/external-dns/pull/4334)
- build(deps): bump the dev-dependencies group with 9 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4349](https://togithub.com/kubernetes-sigs/external-dns/pull/4349)
- build(deps): bump the dev-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4341](https://togithub.com/kubernetes-sigs/external-dns/pull/4341)
- Add `dnsendpoint` CRD to Helm chart by
[@&#8203;onedr0p](https://togithub.com/onedr0p) in
[https://github.com/kubernetes-sigs/external-dns/pull/4322](https://togithub.com/kubernetes-sigs/external-dns/pull/4322)
- build(deps): bump the dev-dependencies group with 13 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4361](https://togithub.com/kubernetes-sigs/external-dns/pull/4361)
- build(deps): bump GrantBirki/json-yaml-validate from 2.6.1 to 2.6.2 in
the dev-dependencies group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4364](https://togithub.com/kubernetes-sigs/external-dns/pull/4364)
- chore(chart): Released chart for v0.14.1 by
[@&#8203;stevehipwell](https://togithub.com/stevehipwell) in
[https://github.com/kubernetes-sigs/external-dns/pull/4357](https://togithub.com/kubernetes-sigs/external-dns/pull/4357)
- chore: alphabetical order on providers by
[@&#8203;mloiseleur](https://togithub.com/mloiseleur) in
[https://github.com/kubernetes-sigs/external-dns/pull/4350](https://togithub.com/kubernetes-sigs/external-dns/pull/4350)
- doc: advertise current plan on providers by
[@&#8203;mloiseleur](https://togithub.com/mloiseleur) in
[https://github.com/kubernetes-sigs/external-dns/pull/4365](https://togithub.com/kubernetes-sigs/external-dns/pull/4365)
- Fix(ipv6): support ipv6 shortener and expander equal by
[@&#8203;dongjiang1989](https://togithub.com/dongjiang1989) in
[https://github.com/kubernetes-sigs/external-dns/pull/4351](https://togithub.com/kubernetes-sigs/external-dns/pull/4351)
- feat(WebhookProvider): Let WebhookProvider return `SoftError` on
response status codes >= 500 by
[@&#8203;SimonKienzler](https://togithub.com/SimonKienzler) in
[https://github.com/kubernetes-sigs/external-dns/pull/4319](https://togithub.com/kubernetes-sigs/external-dns/pull/4319)
- Webhook provider: Use correct error gauge in `AdjustEndpoints()` func
by [@&#8203;SimonKienzler](https://togithub.com/SimonKienzler) in
[https://github.com/kubernetes-sigs/external-dns/pull/4374](https://togithub.com/kubernetes-sigs/external-dns/pull/4374)
- build(deps): bump the dev-dependencies group with 18 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4381](https://togithub.com/kubernetes-sigs/external-dns/pull/4381)
- Add exclude domains value in Chart by
[@&#8203;bford-evs](https://togithub.com/bford-evs) in
[https://github.com/kubernetes-sigs/external-dns/pull/4380](https://togithub.com/kubernetes-sigs/external-dns/pull/4380)
- docs(aws): fix typo and upgrade cleanup flow by
[@&#8203;franzudev](https://togithub.com/franzudev) in
[https://github.com/kubernetes-sigs/external-dns/pull/4389](https://togithub.com/kubernetes-sigs/external-dns/pull/4389)
- docs(gke): detail how to configure workload identity by
[@&#8203;userbradley](https://togithub.com/userbradley) in
[https://github.com/kubernetes-sigs/external-dns/pull/4373](https://togithub.com/kubernetes-sigs/external-dns/pull/4373)
- chore(ci): fix failing test by
[@&#8203;mloiseleur](https://togithub.com/mloiseleur) in
[https://github.com/kubernetes-sigs/external-dns/pull/4397](https://togithub.com/kubernetes-sigs/external-dns/pull/4397)
- chore: Update controller-tools version to v0.14.0 by
[@&#8203;dongjiang1989](https://togithub.com/dongjiang1989) in
[https://github.com/kubernetes-sigs/external-dns/pull/4400](https://togithub.com/kubernetes-sigs/external-dns/pull/4400)
- chore(ci): update golangci-lint to v1.57.2 by
[@&#8203;dongjiang1989](https://togithub.com/dongjiang1989) in
[https://github.com/kubernetes-sigs/external-dns/pull/4406](https://togithub.com/kubernetes-sigs/external-dns/pull/4406)
- chore: upgrade ExternalDNS to go 1.22.2 by
[@&#8203;mloiseleur](https://togithub.com/mloiseleur) in
[https://github.com/kubernetes-sigs/external-dns/pull/4414](https://togithub.com/kubernetes-sigs/external-dns/pull/4414)
- build(deps): bump the dev-dependencies group across 1 directory with 4
updates by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4412](https://togithub.com/kubernetes-sigs/external-dns/pull/4412)
- build(deps): bump the dev-dependencies group across 1 directory with
24 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4416](https://togithub.com/kubernetes-sigs/external-dns/pull/4416)
- custom Azure Active Directory Authority Host by
[@&#8203;Jeremy-Boyle](https://togithub.com/Jeremy-Boyle) in
[https://github.com/kubernetes-sigs/external-dns/pull/4210](https://togithub.com/kubernetes-sigs/external-dns/pull/4210)
- feat(DNSimple): User API tokens by
[@&#8203;IntegralProgrammer](https://togithub.com/IntegralProgrammer) in
[https://github.com/kubernetes-sigs/external-dns/pull/4274](https://togithub.com/kubernetes-sigs/external-dns/pull/4274)
- docs: annotation placement for azuredns tutorial by
[@&#8203;jonas-budde](https://togithub.com/jonas-budde) in
[https://github.com/kubernetes-sigs/external-dns/pull/4415](https://togithub.com/kubernetes-sigs/external-dns/pull/4415)
- feat(azure): add zone name filter for Azure Private DNS by
[@&#8203;khuedoan](https://togithub.com/khuedoan) in
[https://github.com/kubernetes-sigs/external-dns/pull/4346](https://togithub.com/kubernetes-sigs/external-dns/pull/4346)
- test: detect no change necessary with provider specific config by
[@&#8203;szuecs](https://togithub.com/szuecs) in
[https://github.com/kubernetes-sigs/external-dns/pull/4189](https://togithub.com/kubernetes-sigs/external-dns/pull/4189)
- docs: add setup example with helm chart on some providers by
[@&#8203;omerap12](https://togithub.com/omerap12) in
[https://github.com/kubernetes-sigs/external-dns/pull/4405](https://togithub.com/kubernetes-sigs/external-dns/pull/4405)
- test: controller run() and successfully shutdown by
[@&#8203;szuecs](https://togithub.com/szuecs) in
[https://github.com/kubernetes-sigs/external-dns/pull/3639](https://togithub.com/kubernetes-sigs/external-dns/pull/3639)
- fix syntax on cloudflare externalDNS by
[@&#8203;ilyesAj](https://togithub.com/ilyesAj) in
[https://github.com/kubernetes-sigs/external-dns/pull/4436](https://togithub.com/kubernetes-sigs/external-dns/pull/4436)
- build(deps): bump the dev-dependencies group across 1 directory with
11 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4440](https://togithub.com/kubernetes-sigs/external-dns/pull/4440)
- chore(chart): Adding extra containers by
[@&#8203;omerap12](https://togithub.com/omerap12) in
[https://github.com/kubernetes-sigs/external-dns/pull/4432](https://togithub.com/kubernetes-sigs/external-dns/pull/4432)
- aws: add ca-west-1 region by
[@&#8203;jeremy-albuixech](https://togithub.com/jeremy-albuixech) in
[https://github.com/kubernetes-sigs/external-dns/pull/4444](https://togithub.com/kubernetes-sigs/external-dns/pull/4444)
- fix: duplicated endpoint per hosted zone by
[@&#8203;leonardocaylent](https://togithub.com/leonardocaylent) in
[https://github.com/kubernetes-sigs/external-dns/pull/4296](https://togithub.com/kubernetes-sigs/external-dns/pull/4296)
- build(deps): bump actions/checkout from 4.1.4 to 4.1.5 in the
dev-dependencies group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4438](https://togithub.com/kubernetes-sigs/external-dns/pull/4438)
- Add IPv6 AAAA record support to PiHole provider by
[@&#8203;PseudoResonance](https://togithub.com/PseudoResonance) in
[https://github.com/kubernetes-sigs/external-dns/pull/4324](https://togithub.com/kubernetes-sigs/external-dns/pull/4324)
- fix: soft error on cloudflare rate limits by
[@&#8203;ebachle](https://togithub.com/ebachle) in
[https://github.com/kubernetes-sigs/external-dns/pull/4437](https://togithub.com/kubernetes-sigs/external-dns/pull/4437)
- Update cloudflare.md by
[@&#8203;mfreeman451](https://togithub.com/mfreeman451) in
[https://github.com/kubernetes-sigs/external-dns/pull/4449](https://togithub.com/kubernetes-sigs/external-dns/pull/4449)
- Fix headings, whitespace by
[@&#8203;stefanlasiewski](https://togithub.com/stefanlasiewski) in
[https://github.com/kubernetes-sigs/external-dns/pull/4457](https://togithub.com/kubernetes-sigs/external-dns/pull/4457)
- docs: add reference to anexia webhook provider by
[@&#8203;ProbstenHias](https://togithub.com/ProbstenHias) in
[https://github.com/kubernetes-sigs/external-dns/pull/4441](https://togithub.com/kubernetes-sigs/external-dns/pull/4441)
- fix logline mentioning plugin api by
[@&#8203;Raffo](https://togithub.com/Raffo) in
[https://github.com/kubernetes-sigs/external-dns/pull/4459](https://togithub.com/kubernetes-sigs/external-dns/pull/4459)
- docs: lint gke docs + make terraform config more secure by
[@&#8203;DrFaust92](https://togithub.com/DrFaust92) in
[https://github.com/kubernetes-sigs/external-dns/pull/4456](https://togithub.com/kubernetes-sigs/external-dns/pull/4456)
- build(deps): bump action-stars/install-tool-from-github-release from
0.2.2 to 0.2.3 in the dev-dependencies group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4464](https://togithub.com/kubernetes-sigs/external-dns/pull/4464)
- changed documentation to include more details description when using
API Tokens by [@&#8203;rhjensen79](https://togithub.com/rhjensen79) in
[https://github.com/kubernetes-sigs/external-dns/pull/4474](https://togithub.com/kubernetes-sigs/external-dns/pull/4474)
- fix: add clarification to endpoint unit tests by
[@&#8203;leonardocaylent](https://togithub.com/leonardocaylent) in
[https://github.com/kubernetes-sigs/external-dns/pull/4462](https://togithub.com/kubernetes-sigs/external-dns/pull/4462)
- build(deps): bump the dev-dependencies group across 1 directory with
19 updates by [@&#8203;mloiseleur](https://togithub.com/mloiseleur) in
[https://github.com/kubernetes-sigs/external-dns/pull/4476](https://togithub.com/kubernetes-sigs/external-dns/pull/4476)
- build(deps): bump the dev-dependencies group across 1 directory with
19 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/kubernetes-sigs/external-dns/pull/4475](https://togithub.com/kubernetes-sigs/external-dns/pull/4475)

#### New Contributors

- [@&#8203;onedr0p](https://togithub.com/onedr0p) made their first
contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4322](https://togithub.com/kubernetes-sigs/external-dns/pull/4322)
- [@&#8203;SimonKienzler](https://togithub.com/SimonKienzler) made their
first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4319](https://togithub.com/kubernetes-sigs/external-dns/pull/4319)
- [@&#8203;bford-evs](https://togithub.com/bford-evs) made their first
contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4380](https://togithub.com/kubernetes-sigs/external-dns/pull/4380)
- [@&#8203;franzudev](https://togithub.com/franzudev) made their first
contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4389](https://togithub.com/kubernetes-sigs/external-dns/pull/4389)
- [@&#8203;userbradley](https://togithub.com/userbradley) made their
first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4373](https://togithub.com/kubernetes-sigs/external-dns/pull/4373)
- [@&#8203;Jeremy-Boyle](https://togithub.com/Jeremy-Boyle) made their
first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4210](https://togithub.com/kubernetes-sigs/external-dns/pull/4210)
- [@&#8203;IntegralProgrammer](https://togithub.com/IntegralProgrammer)
made their first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4274](https://togithub.com/kubernetes-sigs/external-dns/pull/4274)
- [@&#8203;jonas-budde](https://togithub.com/jonas-budde) made their
first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4415](https://togithub.com/kubernetes-sigs/external-dns/pull/4415)
- [@&#8203;khuedoan](https://togithub.com/khuedoan) made their first
contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4346](https://togithub.com/kubernetes-sigs/external-dns/pull/4346)
- [@&#8203;omerap12](https://togithub.com/omerap12) made their first
contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4405](https://togithub.com/kubernetes-sigs/external-dns/pull/4405)
- [@&#8203;ilyesAj](https://togithub.com/ilyesAj) made their first
contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4436](https://togithub.com/kubernetes-sigs/external-dns/pull/4436)
- [@&#8203;jeremy-albuixech](https://togithub.com/jeremy-albuixech) made
their first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4444](https://togithub.com/kubernetes-sigs/external-dns/pull/4444)
- [@&#8203;leonardocaylent](https://togithub.com/leonardocaylent) made
their first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4296](https://togithub.com/kubernetes-sigs/external-dns/pull/4296)
- [@&#8203;PseudoResonance](https://togithub.com/PseudoResonance) made
their first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4324](https://togithub.com/kubernetes-sigs/external-dns/pull/4324)
- [@&#8203;ebachle](https://togithub.com/ebachle) made their first
contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4437](https://togithub.com/kubernetes-sigs/external-dns/pull/4437)
- [@&#8203;mfreeman451](https://togithub.com/mfreeman451) made their
first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4449](https://togithub.com/kubernetes-sigs/external-dns/pull/4449)
- [@&#8203;ProbstenHias](https://togithub.com/ProbstenHias) made their
first contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4441](https://togithub.com/kubernetes-sigs/external-dns/pull/4441)
- [@&#8203;DrFaust92](https://togithub.com/DrFaust92) made their first
contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4456](https://togithub.com/kubernetes-sigs/external-dns/pull/4456)
- [@&#8203;rhjensen79](https://togithub.com/rhjensen79) made their first
contribution in
[https://github.com/kubernetes-sigs/external-dns/pull/4474](https://togithub.com/kubernetes-sigs/external-dns/pull/4474)

**Full Changelog**:
kubernetes-sigs/external-dns@v0.14.1...v0.14.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants